| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551 |
- <?php
- /*
- * This file is part of the Symfony package.
- *
- * (c) Fabien Potencier <fabien@symfony.com>
- *
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
- namespace Symfony\Component\HttpKernel\Tests\DependencyInjection;
- use PHPUnit\Framework\TestCase;
- use Symfony\Component\DependencyInjection\Argument\ServiceClosureArgument;
- use Symfony\Component\DependencyInjection\Attribute\Target;
- use Symfony\Component\DependencyInjection\ChildDefinition;
- use Symfony\Component\DependencyInjection\ContainerAwareInterface;
- use Symfony\Component\DependencyInjection\ContainerAwareTrait;
- use Symfony\Component\DependencyInjection\ContainerBuilder;
- use Symfony\Component\DependencyInjection\ContainerInterface;
- use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
- use Symfony\Component\DependencyInjection\Reference;
- use Symfony\Component\DependencyInjection\ServiceLocator;
- use Symfony\Component\DependencyInjection\TypedReference;
- use Symfony\Component\HttpFoundation\Response;
- use Symfony\Component\HttpKernel\DependencyInjection\RegisterControllerArgumentLocatorsPass;
- use Symfony\Component\HttpKernel\Tests\Fixtures\Suit;
- class RegisterControllerArgumentLocatorsPassTest extends TestCase
- {
- public function testInvalidClass()
- {
- $this->expectException(InvalidArgumentException::class);
- $this->expectExceptionMessage('Class "Symfony\Component\HttpKernel\Tests\DependencyInjection\NotFound" used for service "foo" cannot be found.');
- $container = new ContainerBuilder();
- $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', NotFound::class)
- ->addTag('controller.service_arguments')
- ;
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- }
- public function testNoAction()
- {
- $this->expectException(InvalidArgumentException::class);
- $this->expectExceptionMessage('Missing "action" attribute on tag "controller.service_arguments" {"argument":"bar"} for service "foo".');
- $container = new ContainerBuilder();
- $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', RegisterTestController::class)
- ->addTag('controller.service_arguments', ['argument' => 'bar'])
- ;
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- }
- public function testNoArgument()
- {
- $this->expectException(InvalidArgumentException::class);
- $this->expectExceptionMessage('Missing "argument" attribute on tag "controller.service_arguments" {"action":"fooAction"} for service "foo".');
- $container = new ContainerBuilder();
- $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', RegisterTestController::class)
- ->addTag('controller.service_arguments', ['action' => 'fooAction'])
- ;
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- }
- public function testNoService()
- {
- $this->expectException(InvalidArgumentException::class);
- $this->expectExceptionMessage('Missing "id" attribute on tag "controller.service_arguments" {"action":"fooAction","argument":"bar"} for service "foo".');
- $container = new ContainerBuilder();
- $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', RegisterTestController::class)
- ->addTag('controller.service_arguments', ['action' => 'fooAction', 'argument' => 'bar'])
- ;
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- }
- public function testInvalidMethod()
- {
- $this->expectException(InvalidArgumentException::class);
- $this->expectExceptionMessage('Invalid "action" attribute on tag "controller.service_arguments" for service "foo": no public "barAction()" method found on class "Symfony\Component\HttpKernel\Tests\DependencyInjection\RegisterTestController".');
- $container = new ContainerBuilder();
- $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', RegisterTestController::class)
- ->addTag('controller.service_arguments', ['action' => 'barAction', 'argument' => 'bar', 'id' => 'bar_service'])
- ;
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- }
- public function testInvalidArgument()
- {
- $this->expectException(InvalidArgumentException::class);
- $this->expectExceptionMessage('Invalid "controller.service_arguments" tag for service "foo": method "fooAction()" has no "baz" argument on class "Symfony\Component\HttpKernel\Tests\DependencyInjection\RegisterTestController".');
- $container = new ContainerBuilder();
- $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', RegisterTestController::class)
- ->addTag('controller.service_arguments', ['action' => 'fooAction', 'argument' => 'baz', 'id' => 'bar'])
- ;
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- }
- public function testAllActions()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', RegisterTestController::class)
- ->addTag('controller.service_arguments')
- ;
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $this->assertEquals(['foo::fooAction'], array_keys($locator));
- $this->assertInstanceof(ServiceClosureArgument::class, $locator['foo::fooAction']);
- $locator = $container->getDefinition((string) $locator['foo::fooAction']->getValues()[0]);
- $this->assertSame(ServiceLocator::class, $locator->getClass());
- $this->assertFalse($locator->isPublic());
- $expected = ['bar' => new ServiceClosureArgument(new TypedReference(ControllerDummy::class, ControllerDummy::class, ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE, 'bar'))];
- $this->assertEquals($expected, $locator->getArgument(0));
- }
- public function testExplicitArgument()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', RegisterTestController::class)
- ->addTag('controller.service_arguments', ['action' => 'fooAction', 'argument' => 'bar', 'id' => 'bar'])
- ->addTag('controller.service_arguments', ['action' => 'fooAction', 'argument' => 'bar', 'id' => 'baz']) // should be ignored, the first wins
- ;
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $locator = $container->getDefinition((string) $locator['foo::fooAction']->getValues()[0]);
- $expected = ['bar' => new ServiceClosureArgument(new TypedReference('bar', ControllerDummy::class, ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE))];
- $this->assertEquals($expected, $locator->getArgument(0));
- }
- public function testOptionalArgument()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', RegisterTestController::class)
- ->addTag('controller.service_arguments', ['action' => 'fooAction', 'argument' => 'bar', 'id' => '?bar'])
- ;
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $locator = $container->getDefinition((string) $locator['foo::fooAction']->getValues()[0]);
- $expected = ['bar' => new ServiceClosureArgument(new TypedReference('bar', ControllerDummy::class, ContainerInterface::IGNORE_ON_INVALID_REFERENCE))];
- $this->assertEquals($expected, $locator->getArgument(0));
- }
- public function testSkipSetContainer()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', ContainerAwareRegisterTestController::class)
- ->addTag('controller.service_arguments');
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $this->assertSame(['foo::fooAction'], array_keys($locator));
- }
- public function testExceptionOnNonExistentTypeHint()
- {
- $this->expectException(\RuntimeException::class);
- $this->expectExceptionMessage('Cannot determine controller argument for "Symfony\Component\HttpKernel\Tests\DependencyInjection\NonExistentClassController::fooAction()": the $nonExistent argument is type-hinted with the non-existent class or interface: "Symfony\Component\HttpKernel\Tests\DependencyInjection\NonExistentClass". Did you forget to add a use statement?');
- $container = new ContainerBuilder();
- $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', NonExistentClassController::class)
- ->addTag('controller.service_arguments');
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $error = $container->getDefinition('argument_resolver.service')->getArgument(0);
- $error = $container->getDefinition($error)->getArgument(0)['foo::fooAction']->getValues()[0];
- $error = $container->getDefinition($error)->getArgument(0)['nonExistent']->getValues()[0];
- $container->get($error);
- }
- public function testExceptionOnNonExistentTypeHintDifferentNamespace()
- {
- $this->expectException(\RuntimeException::class);
- $this->expectExceptionMessage('Cannot determine controller argument for "Symfony\Component\HttpKernel\Tests\DependencyInjection\NonExistentClassDifferentNamespaceController::fooAction()": the $nonExistent argument is type-hinted with the non-existent class or interface: "Acme\NonExistentClass".');
- $container = new ContainerBuilder();
- $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', NonExistentClassDifferentNamespaceController::class)
- ->addTag('controller.service_arguments');
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $error = $container->getDefinition('argument_resolver.service')->getArgument(0);
- $error = $container->getDefinition($error)->getArgument(0)['foo::fooAction']->getValues()[0];
- $error = $container->getDefinition($error)->getArgument(0)['nonExistent']->getValues()[0];
- $container->get($error);
- }
- public function testNoExceptionOnNonExistentTypeHintOptionalArg()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', NonExistentClassOptionalController::class)
- ->addTag('controller.service_arguments');
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $this->assertEqualsCanonicalizing(['foo::barAction', 'foo::fooAction'], array_keys($locator));
- }
- public function testArgumentWithNoTypeHintIsOk()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', ArgumentWithoutTypeController::class)
- ->addTag('controller.service_arguments');
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $this->assertEmpty(array_keys($locator));
- }
- public function testControllersAreMadePublic()
- {
- $container = new ContainerBuilder();
- $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', ArgumentWithoutTypeController::class)
- ->setPublic(false)
- ->addTag('controller.service_arguments');
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $this->assertTrue($container->getDefinition('foo')->isPublic());
- }
- /**
- * @dataProvider provideBindings
- */
- public function testBindings($bindingName)
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', RegisterTestController::class)
- ->setBindings([$bindingName => new Reference('foo')])
- ->addTag('controller.service_arguments');
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $locator = $container->getDefinition((string) $locator['foo::fooAction']->getValues()[0]);
- $expected = ['bar' => new ServiceClosureArgument(new Reference('foo'))];
- $this->assertEquals($expected, $locator->getArgument(0));
- }
- public static function provideBindings()
- {
- return [
- [ControllerDummy::class.'$bar'],
- [ControllerDummy::class],
- ['$bar'],
- ];
- }
- /**
- * @dataProvider provideBindScalarValueToControllerArgument
- */
- public function testBindScalarValueToControllerArgument($bindingKey)
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service', 'stdClass')->addArgument([]);
- $container->register('foo', ArgumentWithoutTypeController::class)
- ->setBindings([$bindingKey => '%foo%'])
- ->addTag('controller.service_arguments');
- $container->setParameter('foo', 'foo_val');
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locatorId = (string) $resolver->getArgument(0);
- $container->getDefinition($locatorId)->setPublic(true);
- $container->compile();
- $locator = $container->get($locatorId);
- $this->assertSame('foo_val', $locator->get('foo::fooAction')->get('someArg'));
- }
- public static function provideBindScalarValueToControllerArgument()
- {
- yield ['$someArg'];
- yield ['string $someArg'];
- }
- public function testBindingsOnChildDefinitions()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register('parent', ArgumentWithoutTypeController::class);
- $container->setDefinition('child', (new ChildDefinition('parent'))
- ->setBindings(['$someArg' => new Reference('parent')])
- ->addTag('controller.service_arguments')
- );
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $this->assertInstanceOf(ServiceClosureArgument::class, $locator['child::fooAction']);
- $locator = $container->getDefinition((string) $locator['child::fooAction']->getValues()[0])->getArgument(0);
- $this->assertInstanceOf(ServiceClosureArgument::class, $locator['someArg']);
- $this->assertEquals(new Reference('parent'), $locator['someArg']->getValues()[0]);
- }
- public function testNotTaggedControllerServiceReceivesLocatorArgument()
- {
- $container = new ContainerBuilder();
- $container->register('argument_resolver.not_tagged_controller')->addArgument([]);
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locatorArgument = $container->getDefinition('argument_resolver.not_tagged_controller')->getArgument(0);
- $this->assertInstanceOf(Reference::class, $locatorArgument);
- }
- public function testAlias()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', RegisterTestController::class)
- ->addTag('controller.service_arguments');
- $container->setAlias(RegisterTestController::class, 'foo')->setPublic(true);
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $this->assertEqualsCanonicalizing([RegisterTestController::class.'::fooAction', 'foo::fooAction'], array_keys($locator));
- }
- /**
- * @requires PHP 8.1
- */
- public function testEnumArgumentIsIgnored()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register('foo', NonNullableEnumArgumentWithDefaultController::class)
- ->addTag('controller.service_arguments')
- ;
- $pass = new RegisterControllerArgumentLocatorsPass();
- $pass->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $this->assertEmpty(array_keys($locator), 'enum typed argument is ignored');
- }
- /**
- * @requires PHP 8
- */
- public function testBindWithTarget()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service')->addArgument([]);
- $container->register(ControllerDummy::class, 'bar');
- $container->register(ControllerDummy::class.' $imageStorage', 'baz');
- $container->register('foo', WithTarget::class)
- ->setBindings(['string $someApiKey' => new Reference('the_api_key')])
- ->addTag('controller.service_arguments');
- (new RegisterControllerArgumentLocatorsPass())->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $locator = $container->getDefinition((string) $locator['foo::fooAction']->getValues()[0]);
- $expected = [
- 'apiKey' => new ServiceClosureArgument(new Reference('the_api_key')),
- 'service1' => new ServiceClosureArgument(new TypedReference(ControllerDummy::class, ControllerDummy::class, ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE, 'imageStorage')),
- 'service2' => new ServiceClosureArgument(new TypedReference(ControllerDummy::class, ControllerDummy::class, ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE, 'service2')),
- ];
- $this->assertEquals($expected, $locator->getArgument(0));
- }
- public function testResponseArgumentIsIgnored()
- {
- $container = new ContainerBuilder();
- $resolver = $container->register('argument_resolver.service', 'stdClass')->addArgument([]);
- $container->register('foo', WithResponseArgument::class)
- ->addTag('controller.service_arguments');
- (new RegisterControllerArgumentLocatorsPass())->process($container);
- $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
- $this->assertEmpty(array_keys($locator), 'Response typed argument is ignored');
- }
- }
- class RegisterTestController
- {
- public function __construct(ControllerDummy $bar)
- {
- }
- public function fooAction(ControllerDummy $bar)
- {
- }
- protected function barAction(ControllerDummy $bar)
- {
- }
- }
- class ContainerAwareRegisterTestController implements ContainerAwareInterface
- {
- use ContainerAwareTrait;
- public function fooAction(ControllerDummy $bar)
- {
- }
- }
- class ControllerDummy
- {
- }
- class NonExistentClassController
- {
- public function fooAction(NonExistentClass $nonExistent)
- {
- }
- }
- class NonExistentClassDifferentNamespaceController
- {
- public function fooAction(\Acme\NonExistentClass $nonExistent)
- {
- }
- }
- class NonExistentClassOptionalController
- {
- public function fooAction(NonExistentClass $nonExistent = null)
- {
- }
- public function barAction(NonExistentClass $nonExistent = null, $bar)
- {
- }
- }
- class ArgumentWithoutTypeController
- {
- public function fooAction(string $someArg)
- {
- }
- }
- class NonNullableEnumArgumentWithDefaultController
- {
- public function fooAction(Suit $suit = Suit::Spades)
- {
- }
- }
- class WithTarget
- {
- public function fooAction(
- #[Target('some.api.key')]
- string $apiKey,
- #[Target('image.storage')]
- ControllerDummy $service1,
- ControllerDummy $service2
- ) {
- }
- }
- class WithResponseArgument
- {
- public function fooAction(Response $response, ?Response $nullableResponse)
- {
- }
- }
|