RequestDataCollectorTest.php 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471
  1. <?php
  2. /*
  3. * This file is part of the Symfony package.
  4. *
  5. * (c) Fabien Potencier <fabien@symfony.com>
  6. *
  7. * For the full copyright and license information, please view the LICENSE
  8. * file that was distributed with this source code.
  9. */
  10. namespace Symfony\Component\HttpKernel\Tests\DataCollector;
  11. use PHPUnit\Framework\TestCase;
  12. use Symfony\Component\EventDispatcher\EventDispatcher;
  13. use Symfony\Component\HttpFoundation\Cookie;
  14. use Symfony\Component\HttpFoundation\ParameterBag;
  15. use Symfony\Component\HttpFoundation\RedirectResponse;
  16. use Symfony\Component\HttpFoundation\Request;
  17. use Symfony\Component\HttpFoundation\RequestStack;
  18. use Symfony\Component\HttpFoundation\Response;
  19. use Symfony\Component\HttpFoundation\Session\Session;
  20. use Symfony\Component\HttpFoundation\Session\SessionBagInterface;
  21. use Symfony\Component\HttpFoundation\Session\SessionInterface;
  22. use Symfony\Component\HttpFoundation\Session\Storage\MetadataBag;
  23. use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
  24. use Symfony\Component\HttpKernel\Controller\ArgumentResolverInterface;
  25. use Symfony\Component\HttpKernel\Controller\ControllerResolverInterface;
  26. use Symfony\Component\HttpKernel\DataCollector\RequestDataCollector;
  27. use Symfony\Component\HttpKernel\Event\ControllerEvent;
  28. use Symfony\Component\HttpKernel\Event\ResponseEvent;
  29. use Symfony\Component\HttpKernel\HttpKernel;
  30. use Symfony\Component\HttpKernel\HttpKernelInterface;
  31. use Symfony\Component\HttpKernel\Tests\Fixtures\DataCollector\DummyController;
  32. class RequestDataCollectorTest extends TestCase
  33. {
  34. public function testCollect()
  35. {
  36. $c = new RequestDataCollector();
  37. $c->collect($request = $this->createRequest(), $this->createResponse());
  38. $c->lateCollect();
  39. $attributes = $c->getRequestAttributes();
  40. $this->assertSame('request', $c->getName());
  41. $this->assertInstanceOf(ParameterBag::class, $c->getRequestHeaders());
  42. $this->assertInstanceOf(ParameterBag::class, $c->getRequestServer());
  43. $this->assertInstanceOf(ParameterBag::class, $c->getRequestCookies());
  44. $this->assertInstanceOf(ParameterBag::class, $attributes);
  45. $this->assertInstanceOf(ParameterBag::class, $c->getRequestRequest());
  46. $this->assertInstanceOf(ParameterBag::class, $c->getRequestQuery());
  47. $this->assertInstanceOf(ParameterBag::class, $c->getResponseCookies());
  48. $this->assertSame('html', $c->getFormat());
  49. $this->assertEquals('foobar', $c->getRoute());
  50. $this->assertEquals(['name' => 'foo'], $c->getRouteParams());
  51. $this->assertSame([], $c->getSessionAttributes());
  52. $this->assertSame('en', $c->getLocale());
  53. $this->assertContainsEquals(__FILE__, $attributes->get('resource'));
  54. $this->assertSame('stdClass', $attributes->get('object')->getType());
  55. $this->assertInstanceOf(ParameterBag::class, $c->getResponseHeaders());
  56. $this->assertSame('OK', $c->getStatusText());
  57. $this->assertSame(200, $c->getStatusCode());
  58. $this->assertSame('application/json', $c->getContentType());
  59. }
  60. public function testCollectWithoutRouteParams()
  61. {
  62. $request = $this->createRequest([]);
  63. $c = new RequestDataCollector();
  64. $c->collect($request, $this->createResponse());
  65. $c->lateCollect();
  66. $this->assertEquals([], $c->getRouteParams());
  67. }
  68. /**
  69. * @dataProvider provideControllerCallables
  70. */
  71. public function testControllerInspection($name, $callable, $expected)
  72. {
  73. $c = new RequestDataCollector();
  74. $request = $this->createRequest();
  75. $response = $this->createResponse();
  76. $this->injectController($c, $callable, $request);
  77. $c->collect($request, $response);
  78. $c->lateCollect();
  79. $this->assertSame($expected, $c->getController()->getValue(true), sprintf('Testing: %s', $name));
  80. }
  81. public static function provideControllerCallables(): array
  82. {
  83. // make sure we always match the line number
  84. $controller = new DummyController();
  85. $r1 = new \ReflectionMethod($controller, 'regularCallable');
  86. $r2 = new \ReflectionMethod($controller, 'staticControllerMethod');
  87. $r3 = new \ReflectionClass($controller);
  88. // test name, callable, expected
  89. return [
  90. [
  91. '"Regular" callable',
  92. [$controller, 'regularCallable'],
  93. [
  94. 'class' => DummyController::class,
  95. 'method' => 'regularCallable',
  96. 'file' => $r1->getFileName(),
  97. 'line' => $r1->getStartLine(),
  98. ],
  99. ],
  100. [
  101. 'Closure',
  102. function () { return 'foo'; },
  103. [
  104. 'class' => __NAMESPACE__.'\{closure}',
  105. 'method' => null,
  106. 'file' => __FILE__,
  107. 'line' => __LINE__ - 5,
  108. ],
  109. ],
  110. [
  111. 'First-class callable closure',
  112. \PHP_VERSION_ID >= 80100 ? eval('return $controller->regularCallable(...);') : [$controller, 'regularCallable'],
  113. [
  114. 'class' => DummyController::class,
  115. 'method' => 'regularCallable',
  116. 'file' => $r1->getFileName(),
  117. 'line' => $r1->getStartLine(),
  118. ],
  119. ],
  120. [
  121. 'Static callback as string',
  122. DummyController::class.'::staticControllerMethod',
  123. [
  124. 'class' => DummyController::class,
  125. 'method' => 'staticControllerMethod',
  126. 'file' => $r2->getFileName(),
  127. 'line' => $r2->getStartLine(),
  128. ],
  129. ],
  130. [
  131. 'Static callable with instance',
  132. [$controller, 'staticControllerMethod'],
  133. [
  134. 'class' => DummyController::class,
  135. 'method' => 'staticControllerMethod',
  136. 'file' => $r2->getFileName(),
  137. 'line' => $r2->getStartLine(),
  138. ],
  139. ],
  140. [
  141. 'Static callable with class name',
  142. [DummyController::class, 'staticControllerMethod'],
  143. [
  144. 'class' => DummyController::class,
  145. 'method' => 'staticControllerMethod',
  146. 'file' => $r2->getFileName(),
  147. 'line' => $r2->getStartLine(),
  148. ],
  149. ],
  150. [
  151. 'Callable with instance depending on __call()',
  152. [$controller, 'magicMethod'],
  153. [
  154. 'class' => DummyController::class,
  155. 'method' => 'magicMethod',
  156. 'file' => 'n/a',
  157. 'line' => 'n/a',
  158. ],
  159. ],
  160. [
  161. 'Callable with class name depending on __callStatic()',
  162. [DummyController::class, 'magicMethod'],
  163. [
  164. 'class' => DummyController::class,
  165. 'method' => 'magicMethod',
  166. 'file' => 'n/a',
  167. 'line' => 'n/a',
  168. ],
  169. ],
  170. [
  171. 'Invokable controller',
  172. $controller,
  173. [
  174. 'class' => DummyController::class,
  175. 'method' => null,
  176. 'file' => $r3->getFileName(),
  177. 'line' => $r3->getStartLine(),
  178. ],
  179. ],
  180. ];
  181. }
  182. public function testItIgnoresInvalidCallables()
  183. {
  184. $request = $this->createRequestWithSession();
  185. $response = new RedirectResponse('/');
  186. $c = new RequestDataCollector();
  187. $c->collect($request, $response);
  188. $this->assertSame('n/a', $c->getController());
  189. }
  190. public function testItAddsRedirectedAttributesWhenRequestContainsSpecificCookie()
  191. {
  192. $request = $this->createRequest();
  193. $request->cookies->add([
  194. 'sf_redirect' => '{}',
  195. ]);
  196. $kernel = $this->createMock(HttpKernelInterface::class);
  197. $c = new RequestDataCollector();
  198. $c->onKernelResponse(new ResponseEvent($kernel, $request, HttpKernelInterface::MAIN_REQUEST, $this->createResponse()));
  199. $this->assertTrue($request->attributes->get('_redirected'));
  200. }
  201. public function testItSetsARedirectCookieIfTheResponseIsARedirection()
  202. {
  203. $c = new RequestDataCollector();
  204. $response = $this->createResponse();
  205. $response->setStatusCode(302);
  206. $response->headers->set('Location', '/somewhere-else');
  207. $c->collect($request = $this->createRequest(), $response);
  208. $c->lateCollect();
  209. $cookie = $this->getCookieByName($response, 'sf_redirect');
  210. $this->assertNotEmpty($cookie->getValue());
  211. $this->assertSame('lax', $cookie->getSameSite());
  212. $this->assertFalse($cookie->isSecure());
  213. }
  214. public function testItCollectsTheRedirectionAndClearTheCookie()
  215. {
  216. $c = new RequestDataCollector();
  217. $request = $this->createRequest();
  218. $request->attributes->set('_redirected', true);
  219. $request->cookies->add([
  220. 'sf_redirect' => '{"method": "POST"}',
  221. ]);
  222. $c->collect($request, $response = $this->createResponse());
  223. $c->lateCollect();
  224. $this->assertEquals('POST', $c->getRedirect()['method']);
  225. $cookie = $this->getCookieByName($response, 'sf_redirect');
  226. $this->assertNull($cookie->getValue());
  227. }
  228. public function testItCollectsTheSessionTraceProperly()
  229. {
  230. $collector = new RequestDataCollector();
  231. $request = $this->createRequest();
  232. // RequestDataCollectorTest doesn't implement SessionInterface or SessionBagInterface, therefore should do nothing.
  233. $collector->collectSessionUsage();
  234. $collector->collect($request, $this->createResponse());
  235. $this->assertSame([], $collector->getSessionUsages());
  236. $collector->reset();
  237. $session = $this->createMock(SessionInterface::class);
  238. $session->method('getMetadataBag')->willReturnCallback(static function () use ($collector) {
  239. $collector->collectSessionUsage();
  240. return new MetadataBag();
  241. });
  242. $session->getMetadataBag();
  243. $collector->collect($request, $this->createResponse());
  244. $collector->lateCollect();
  245. $usages = $collector->getSessionUsages();
  246. $this->assertCount(1, $usages);
  247. $this->assertSame(__FILE__, $usages[0]['file']);
  248. $this->assertSame(__LINE__ - 9, $line = $usages[0]['line']);
  249. $trace = $usages[0]['trace'];
  250. $this->assertSame('getMetadataBag', $trace[0]['function']);
  251. $this->assertSame(self::class, $class = $trace[1]['class']);
  252. $this->assertSame(sprintf('%s:%s', $class, $line), $usages[0]['name']);
  253. }
  254. public function testStatelessCheck()
  255. {
  256. $requestStack = new RequestStack();
  257. $request = $this->createRequest();
  258. $requestStack->push($request);
  259. $collector = new RequestDataCollector($requestStack);
  260. $collector->collect($request, $response = $this->createResponse());
  261. $collector->lateCollect();
  262. $this->assertFalse($collector->getStatelessCheck());
  263. $requestStack = new RequestStack();
  264. $request = $this->createRequest();
  265. $request->attributes->set('_stateless', true);
  266. $requestStack->push($request);
  267. $collector = new RequestDataCollector($requestStack);
  268. $collector->collect($request, $response = $this->createResponse());
  269. $collector->lateCollect();
  270. $this->assertTrue($collector->getStatelessCheck());
  271. $requestStack = new RequestStack();
  272. $request = $this->createRequest();
  273. $collector = new RequestDataCollector($requestStack);
  274. $collector->collect($request, $response = $this->createResponse());
  275. $collector->lateCollect();
  276. $this->assertFalse($collector->getStatelessCheck());
  277. }
  278. public function testItHidesPassword()
  279. {
  280. $c = new RequestDataCollector();
  281. $request = Request::create(
  282. 'http://test.com/login',
  283. 'POST',
  284. ['_password' => ' _password@123'],
  285. [],
  286. [],
  287. [],
  288. '_password=%20_password%40123'
  289. );
  290. $c->collect($request, $this->createResponse());
  291. $c->lateCollect();
  292. $this->assertEquals('******', $c->getRequestRequest()->get('_password'));
  293. $this->assertEquals('_password=******', $c->getContent());
  294. }
  295. protected function createRequest($routeParams = ['name' => 'foo'])
  296. {
  297. $request = Request::create('http://test.com/foo?bar=baz');
  298. $request->attributes->set('foo', 'bar');
  299. $request->attributes->set('_route', 'foobar');
  300. $request->attributes->set('_route_params', $routeParams);
  301. $request->attributes->set('resource', fopen(__FILE__, 'r'));
  302. $request->attributes->set('object', new \stdClass());
  303. return $request;
  304. }
  305. private function createRequestWithSession()
  306. {
  307. $request = $this->createRequest();
  308. $request->attributes->set('_controller', 'Foo::bar');
  309. $request->setSession(new Session(new MockArraySessionStorage()));
  310. $request->getSession()->start();
  311. return $request;
  312. }
  313. protected function createResponse()
  314. {
  315. $response = new Response();
  316. $response->setStatusCode(200);
  317. $response->headers->set('Content-Type', 'application/json');
  318. $response->headers->set('X-Foo-Bar', null);
  319. $response->headers->setCookie(new Cookie('foo', 'bar', 1, '/foo', 'localhost', true, true, false, null));
  320. $response->headers->setCookie(new Cookie('bar', 'foo', new \DateTime('@946684800'), '/', null, false, true, false, null));
  321. $response->headers->setCookie(new Cookie('bazz', 'foo', '2000-12-12', '/', null, false, true, false, null));
  322. return $response;
  323. }
  324. /**
  325. * Inject the given controller callable into the data collector.
  326. */
  327. protected function injectController($collector, $controller, $request)
  328. {
  329. $resolver = $this->createMock(ControllerResolverInterface::class);
  330. $httpKernel = new HttpKernel(new EventDispatcher(), $resolver, null, $this->createMock(ArgumentResolverInterface::class));
  331. $event = new ControllerEvent($httpKernel, $controller, $request, HttpKernelInterface::MAIN_REQUEST);
  332. $collector->onKernelController($event);
  333. }
  334. private function getCookieByName(Response $response, $name)
  335. {
  336. foreach ($response->headers->getCookies() as $cookie) {
  337. if ($cookie->getName() == $name) {
  338. return $cookie;
  339. }
  340. }
  341. throw new \InvalidArgumentException(sprintf('Cookie named "%s" is not in response', $name));
  342. }
  343. /**
  344. * @dataProvider provideJsonContentTypes
  345. */
  346. public function testIsJson($contentType, $expected)
  347. {
  348. $response = $this->createResponse();
  349. $request = $this->createRequest();
  350. $request->headers->set('Content-Type', $contentType);
  351. $c = new RequestDataCollector();
  352. $c->collect($request, $response);
  353. $this->assertSame($expected, $c->isJsonRequest());
  354. }
  355. public static function provideJsonContentTypes(): array
  356. {
  357. return [
  358. ['text/csv', false],
  359. ['application/json', true],
  360. ['application/JSON', true],
  361. ['application/hal+json', true],
  362. ['application/xml+json', true],
  363. ['application/xml', false],
  364. ['', false],
  365. ];
  366. }
  367. /**
  368. * @dataProvider providePrettyJson
  369. */
  370. public function testGetPrettyJsonValidity($content, $expected)
  371. {
  372. $response = $this->createResponse();
  373. $request = Request::create('/', 'POST', [], [], [], [], $content);
  374. $c = new RequestDataCollector();
  375. $c->collect($request, $response);
  376. $this->assertSame($expected, $c->getPrettyJson());
  377. }
  378. public static function providePrettyJson(): array
  379. {
  380. return [
  381. ['null', 'null'],
  382. ['{ "foo": "bar" }', '{
  383. "foo": "bar"
  384. }'],
  385. ['{ "abc" }', null],
  386. ['', null],
  387. ];
  388. }
  389. }