ArgumentResolverTest.php 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326
  1. <?php
  2. /*
  3. * This file is part of the Symfony package.
  4. *
  5. * (c) Fabien Potencier <fabien@symfony.com>
  6. *
  7. * For the full copyright and license information, please view the LICENSE
  8. * file that was distributed with this source code.
  9. */
  10. namespace Symfony\Component\HttpKernel\Tests\Controller;
  11. use PHPUnit\Framework\TestCase;
  12. use Symfony\Component\HttpFoundation\Request;
  13. use Symfony\Component\HttpFoundation\Session\Session;
  14. use Symfony\Component\HttpFoundation\Session\SessionInterface;
  15. use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
  16. use Symfony\Component\HttpKernel\Controller\ArgumentResolver;
  17. use Symfony\Component\HttpKernel\Controller\ArgumentResolver\RequestAttributeValueResolver;
  18. use Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface;
  19. use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadataFactory;
  20. use Symfony\Component\HttpKernel\Tests\Fixtures\Controller\ExtendingRequest;
  21. use Symfony\Component\HttpKernel\Tests\Fixtures\Controller\ExtendingSession;
  22. use Symfony\Component\HttpKernel\Tests\Fixtures\Controller\NullableController;
  23. use Symfony\Component\HttpKernel\Tests\Fixtures\Controller\VariadicController;
  24. class ArgumentResolverTest extends TestCase
  25. {
  26. /** @var ArgumentResolver */
  27. private static $resolver;
  28. public static function setUpBeforeClass(): void
  29. {
  30. $factory = new ArgumentMetadataFactory();
  31. self::$resolver = new ArgumentResolver($factory);
  32. }
  33. public function testDefaultState()
  34. {
  35. $this->assertEquals(self::$resolver, new ArgumentResolver());
  36. $this->assertNotEquals(self::$resolver, new ArgumentResolver(null, [new RequestAttributeValueResolver()]));
  37. }
  38. public function testGetArguments()
  39. {
  40. $request = Request::create('/');
  41. $request->attributes->set('foo', 'foo');
  42. $controller = [new self(), 'controllerWithFoo'];
  43. $this->assertEquals(['foo'], self::$resolver->getArguments($request, $controller), '->getArguments() returns an array of arguments for the controller method');
  44. }
  45. public function testGetArgumentsReturnsEmptyArrayWhenNoArguments()
  46. {
  47. $request = Request::create('/');
  48. $controller = [new self(), 'controllerWithoutArguments'];
  49. $this->assertEquals([], self::$resolver->getArguments($request, $controller), '->getArguments() returns an empty array if the method takes no arguments');
  50. }
  51. public function testGetArgumentsUsesDefaultValue()
  52. {
  53. $request = Request::create('/');
  54. $request->attributes->set('foo', 'foo');
  55. $controller = [new self(), 'controllerWithFooAndDefaultBar'];
  56. $this->assertEquals(['foo', null], self::$resolver->getArguments($request, $controller), '->getArguments() uses default values if present');
  57. }
  58. public function testGetArgumentsOverrideDefaultValueByRequestAttribute()
  59. {
  60. $request = Request::create('/');
  61. $request->attributes->set('foo', 'foo');
  62. $request->attributes->set('bar', 'bar');
  63. $controller = [new self(), 'controllerWithFooAndDefaultBar'];
  64. $this->assertEquals(['foo', 'bar'], self::$resolver->getArguments($request, $controller), '->getArguments() overrides default values if provided in the request attributes');
  65. }
  66. public function testGetArgumentsFromClosure()
  67. {
  68. $request = Request::create('/');
  69. $request->attributes->set('foo', 'foo');
  70. $controller = function ($foo) {};
  71. $this->assertEquals(['foo'], self::$resolver->getArguments($request, $controller));
  72. }
  73. public function testGetArgumentsUsesDefaultValueFromClosure()
  74. {
  75. $request = Request::create('/');
  76. $request->attributes->set('foo', 'foo');
  77. $controller = function ($foo, $bar = 'bar') {};
  78. $this->assertEquals(['foo', 'bar'], self::$resolver->getArguments($request, $controller));
  79. }
  80. public function testGetArgumentsFromInvokableObject()
  81. {
  82. $request = Request::create('/');
  83. $request->attributes->set('foo', 'foo');
  84. $controller = new self();
  85. $this->assertEquals(['foo', null], self::$resolver->getArguments($request, $controller));
  86. // Test default bar overridden by request attribute
  87. $request->attributes->set('bar', 'bar');
  88. $this->assertEquals(['foo', 'bar'], self::$resolver->getArguments($request, $controller));
  89. }
  90. public function testGetArgumentsFromFunctionName()
  91. {
  92. $request = Request::create('/');
  93. $request->attributes->set('foo', 'foo');
  94. $request->attributes->set('foobar', 'foobar');
  95. $controller = __NAMESPACE__.'\controller_function';
  96. $this->assertEquals(['foo', 'foobar'], self::$resolver->getArguments($request, $controller));
  97. }
  98. public function testGetArgumentsFailsOnUnresolvedValue()
  99. {
  100. $request = Request::create('/');
  101. $request->attributes->set('foo', 'foo');
  102. $request->attributes->set('foobar', 'foobar');
  103. $controller = [new self(), 'controllerWithFooBarFoobar'];
  104. try {
  105. self::$resolver->getArguments($request, $controller);
  106. $this->fail('->getArguments() throws a \RuntimeException exception if it cannot determine the argument value');
  107. } catch (\Exception $e) {
  108. $this->assertInstanceOf(\RuntimeException::class, $e, '->getArguments() throws a \RuntimeException exception if it cannot determine the argument value');
  109. }
  110. }
  111. public function testGetArgumentsInjectsRequest()
  112. {
  113. $request = Request::create('/');
  114. $controller = [new self(), 'controllerWithRequest'];
  115. $this->assertEquals([$request], self::$resolver->getArguments($request, $controller), '->getArguments() injects the request');
  116. }
  117. public function testGetArgumentsInjectsExtendingRequest()
  118. {
  119. $request = ExtendingRequest::create('/');
  120. $controller = [new self(), 'controllerWithExtendingRequest'];
  121. $this->assertEquals([$request], self::$resolver->getArguments($request, $controller), '->getArguments() injects the request when extended');
  122. }
  123. public function testGetVariadicArguments()
  124. {
  125. $request = Request::create('/');
  126. $request->attributes->set('foo', 'foo');
  127. $request->attributes->set('bar', ['foo', 'bar']);
  128. $controller = [new VariadicController(), 'action'];
  129. $this->assertEquals(['foo', 'foo', 'bar'], self::$resolver->getArguments($request, $controller));
  130. }
  131. public function testGetVariadicArgumentsWithoutArrayInRequest()
  132. {
  133. $this->expectException(\InvalidArgumentException::class);
  134. $request = Request::create('/');
  135. $request->attributes->set('foo', 'foo');
  136. $request->attributes->set('bar', 'foo');
  137. $controller = [new VariadicController(), 'action'];
  138. self::$resolver->getArguments($request, $controller);
  139. }
  140. public function testGetArgumentWithoutArray()
  141. {
  142. $this->expectException(\InvalidArgumentException::class);
  143. $factory = new ArgumentMetadataFactory();
  144. $valueResolver = $this->createMock(ArgumentValueResolverInterface::class);
  145. $resolver = new ArgumentResolver($factory, [$valueResolver]);
  146. $valueResolver->expects($this->any())->method('supports')->willReturn(true);
  147. $valueResolver->expects($this->any())->method('resolve')->willReturn([]);
  148. $request = Request::create('/');
  149. $request->attributes->set('foo', 'foo');
  150. $request->attributes->set('bar', 'foo');
  151. $controller = [$this, 'controllerWithFooAndDefaultBar'];
  152. $resolver->getArguments($request, $controller);
  153. }
  154. public function testIfExceptionIsThrownWhenMissingAnArgument()
  155. {
  156. $this->expectException(\RuntimeException::class);
  157. $request = Request::create('/');
  158. $controller = [$this, 'controllerWithFoo'];
  159. self::$resolver->getArguments($request, $controller);
  160. }
  161. public function testGetNullableArguments()
  162. {
  163. $request = Request::create('/');
  164. $request->attributes->set('foo', 'foo');
  165. $request->attributes->set('bar', new \stdClass());
  166. $request->attributes->set('last', 'last');
  167. $controller = [new NullableController(), 'action'];
  168. $this->assertEquals(['foo', new \stdClass(), 'value', 'last'], self::$resolver->getArguments($request, $controller));
  169. }
  170. public function testGetNullableArgumentsWithDefaults()
  171. {
  172. $request = Request::create('/');
  173. $request->attributes->set('last', 'last');
  174. $controller = [new NullableController(), 'action'];
  175. $this->assertEquals([null, null, 'value', 'last'], self::$resolver->getArguments($request, $controller));
  176. }
  177. public function testGetSessionArguments()
  178. {
  179. $session = new Session(new MockArraySessionStorage());
  180. $request = Request::create('/');
  181. $request->setSession($session);
  182. $controller = [$this, 'controllerWithSession'];
  183. $this->assertEquals([$session], self::$resolver->getArguments($request, $controller));
  184. }
  185. public function testGetSessionArgumentsWithExtendedSession()
  186. {
  187. $session = new ExtendingSession(new MockArraySessionStorage());
  188. $request = Request::create('/');
  189. $request->setSession($session);
  190. $controller = [$this, 'controllerWithExtendingSession'];
  191. $this->assertEquals([$session], self::$resolver->getArguments($request, $controller));
  192. }
  193. public function testGetSessionArgumentsWithInterface()
  194. {
  195. $session = $this->createMock(SessionInterface::class);
  196. $request = Request::create('/');
  197. $request->setSession($session);
  198. $controller = [$this, 'controllerWithSessionInterface'];
  199. $this->assertEquals([$session], self::$resolver->getArguments($request, $controller));
  200. }
  201. public function testGetSessionMissMatchWithInterface()
  202. {
  203. $this->expectException(\RuntimeException::class);
  204. $session = $this->createMock(SessionInterface::class);
  205. $request = Request::create('/');
  206. $request->setSession($session);
  207. $controller = [$this, 'controllerWithExtendingSession'];
  208. self::$resolver->getArguments($request, $controller);
  209. }
  210. public function testGetSessionMissMatchWithImplementation()
  211. {
  212. $this->expectException(\RuntimeException::class);
  213. $session = new Session(new MockArraySessionStorage());
  214. $request = Request::create('/');
  215. $request->setSession($session);
  216. $controller = [$this, 'controllerWithExtendingSession'];
  217. self::$resolver->getArguments($request, $controller);
  218. }
  219. public function testGetSessionMissMatchOnNull()
  220. {
  221. $this->expectException(\RuntimeException::class);
  222. $request = Request::create('/');
  223. $controller = [$this, 'controllerWithExtendingSession'];
  224. self::$resolver->getArguments($request, $controller);
  225. }
  226. public function __invoke($foo, $bar = null)
  227. {
  228. }
  229. public function controllerWithFoo($foo)
  230. {
  231. }
  232. public function controllerWithoutArguments()
  233. {
  234. }
  235. public function controllerWithFooAndDefaultBar($foo, $bar = null)
  236. {
  237. }
  238. public function controllerWithFooBarFoobar($foo, $bar, $foobar)
  239. {
  240. }
  241. public function controllerWithRequest(Request $request)
  242. {
  243. }
  244. public function controllerWithExtendingRequest(ExtendingRequest $request)
  245. {
  246. }
  247. public function controllerWithSession(Session $session)
  248. {
  249. }
  250. public function controllerWithSessionInterface(SessionInterface $session)
  251. {
  252. }
  253. public function controllerWithExtendingSession(ExtendingSession $session)
  254. {
  255. }
  256. }
  257. function controller_function($foo, $foobar)
  258. {
  259. }