RegisterControllerArgumentLocatorsPassTest.php 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413
  1. <?php
  2. /*
  3. * This file is part of the Symfony package.
  4. *
  5. * (c) Fabien Potencier <fabien@symfony.com>
  6. *
  7. * For the full copyright and license information, please view the LICENSE
  8. * file that was distributed with this source code.
  9. */
  10. namespace Symfony\Component\HttpKernel\Tests\DependencyInjection;
  11. use PHPUnit\Framework\TestCase;
  12. use Symfony\Component\DependencyInjection\Argument\ServiceClosureArgument;
  13. use Symfony\Component\DependencyInjection\ChildDefinition;
  14. use Symfony\Component\DependencyInjection\ContainerAwareInterface;
  15. use Symfony\Component\DependencyInjection\ContainerAwareTrait;
  16. use Symfony\Component\DependencyInjection\ContainerBuilder;
  17. use Symfony\Component\DependencyInjection\ContainerInterface;
  18. use Symfony\Component\DependencyInjection\Reference;
  19. use Symfony\Component\DependencyInjection\ServiceLocator;
  20. use Symfony\Component\DependencyInjection\TypedReference;
  21. use Symfony\Component\HttpKernel\DependencyInjection\RegisterControllerArgumentLocatorsPass;
  22. class RegisterControllerArgumentLocatorsPassTest extends TestCase
  23. {
  24. /**
  25. * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
  26. * @expectedExceptionMessage Class "Symfony\Component\HttpKernel\Tests\DependencyInjection\NotFound" used for service "foo" cannot be found.
  27. */
  28. public function testInvalidClass()
  29. {
  30. $container = new ContainerBuilder();
  31. $container->register('argument_resolver.service')->addArgument([]);
  32. $container->register('foo', NotFound::class)
  33. ->addTag('controller.service_arguments')
  34. ;
  35. $pass = new RegisterControllerArgumentLocatorsPass();
  36. $pass->process($container);
  37. }
  38. /**
  39. * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
  40. * @expectedExceptionMessage Missing "action" attribute on tag "controller.service_arguments" {"argument":"bar"} for service "foo".
  41. */
  42. public function testNoAction()
  43. {
  44. $container = new ContainerBuilder();
  45. $container->register('argument_resolver.service')->addArgument([]);
  46. $container->register('foo', RegisterTestController::class)
  47. ->addTag('controller.service_arguments', ['argument' => 'bar'])
  48. ;
  49. $pass = new RegisterControllerArgumentLocatorsPass();
  50. $pass->process($container);
  51. }
  52. /**
  53. * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
  54. * @expectedExceptionMessage Missing "argument" attribute on tag "controller.service_arguments" {"action":"fooAction"} for service "foo".
  55. */
  56. public function testNoArgument()
  57. {
  58. $container = new ContainerBuilder();
  59. $container->register('argument_resolver.service')->addArgument([]);
  60. $container->register('foo', RegisterTestController::class)
  61. ->addTag('controller.service_arguments', ['action' => 'fooAction'])
  62. ;
  63. $pass = new RegisterControllerArgumentLocatorsPass();
  64. $pass->process($container);
  65. }
  66. /**
  67. * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
  68. * @expectedExceptionMessage Missing "id" attribute on tag "controller.service_arguments" {"action":"fooAction","argument":"bar"} for service "foo".
  69. */
  70. public function testNoService()
  71. {
  72. $container = new ContainerBuilder();
  73. $container->register('argument_resolver.service')->addArgument([]);
  74. $container->register('foo', RegisterTestController::class)
  75. ->addTag('controller.service_arguments', ['action' => 'fooAction', 'argument' => 'bar'])
  76. ;
  77. $pass = new RegisterControllerArgumentLocatorsPass();
  78. $pass->process($container);
  79. }
  80. /**
  81. * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
  82. * @expectedExceptionMessage Invalid "action" attribute on tag "controller.service_arguments" for service "foo": no public "barAction()" method found on class "Symfony\Component\HttpKernel\Tests\DependencyInjection\RegisterTestController".
  83. */
  84. public function testInvalidMethod()
  85. {
  86. $container = new ContainerBuilder();
  87. $container->register('argument_resolver.service')->addArgument([]);
  88. $container->register('foo', RegisterTestController::class)
  89. ->addTag('controller.service_arguments', ['action' => 'barAction', 'argument' => 'bar', 'id' => 'bar_service'])
  90. ;
  91. $pass = new RegisterControllerArgumentLocatorsPass();
  92. $pass->process($container);
  93. }
  94. /**
  95. * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
  96. * @expectedExceptionMessage Invalid "controller.service_arguments" tag for service "foo": method "fooAction()" has no "baz" argument on class "Symfony\Component\HttpKernel\Tests\DependencyInjection\RegisterTestController".
  97. */
  98. public function testInvalidArgument()
  99. {
  100. $container = new ContainerBuilder();
  101. $container->register('argument_resolver.service')->addArgument([]);
  102. $container->register('foo', RegisterTestController::class)
  103. ->addTag('controller.service_arguments', ['action' => 'fooAction', 'argument' => 'baz', 'id' => 'bar'])
  104. ;
  105. $pass = new RegisterControllerArgumentLocatorsPass();
  106. $pass->process($container);
  107. }
  108. public function testAllActions()
  109. {
  110. $container = new ContainerBuilder();
  111. $resolver = $container->register('argument_resolver.service')->addArgument([]);
  112. $container->register('foo', RegisterTestController::class)
  113. ->addTag('controller.service_arguments')
  114. ;
  115. $pass = new RegisterControllerArgumentLocatorsPass();
  116. $pass->process($container);
  117. $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
  118. $this->assertEquals(['foo:fooAction'], array_keys($locator));
  119. $this->assertInstanceof(ServiceClosureArgument::class, $locator['foo:fooAction']);
  120. $locator = $container->getDefinition((string) $locator['foo:fooAction']->getValues()[0]);
  121. $this->assertSame(ServiceLocator::class, $locator->getClass());
  122. $this->assertFalse($locator->isPublic());
  123. $expected = ['bar' => new ServiceClosureArgument(new TypedReference(ControllerDummy::class, ControllerDummy::class, RegisterTestController::class, ContainerInterface::IGNORE_ON_INVALID_REFERENCE))];
  124. $this->assertEquals($expected, $locator->getArgument(0));
  125. }
  126. public function testExplicitArgument()
  127. {
  128. $container = new ContainerBuilder();
  129. $resolver = $container->register('argument_resolver.service')->addArgument([]);
  130. $container->register('foo', RegisterTestController::class)
  131. ->addTag('controller.service_arguments', ['action' => 'fooAction', 'argument' => 'bar', 'id' => 'bar'])
  132. ->addTag('controller.service_arguments', ['action' => 'fooAction', 'argument' => 'bar', 'id' => 'baz']) // should be ignored, the first wins
  133. ;
  134. $pass = new RegisterControllerArgumentLocatorsPass();
  135. $pass->process($container);
  136. $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
  137. $locator = $container->getDefinition((string) $locator['foo:fooAction']->getValues()[0]);
  138. $expected = ['bar' => new ServiceClosureArgument(new TypedReference('bar', ControllerDummy::class, RegisterTestController::class))];
  139. $this->assertEquals($expected, $locator->getArgument(0));
  140. }
  141. public function testOptionalArgument()
  142. {
  143. $container = new ContainerBuilder();
  144. $resolver = $container->register('argument_resolver.service')->addArgument([]);
  145. $container->register('foo', RegisterTestController::class)
  146. ->addTag('controller.service_arguments', ['action' => 'fooAction', 'argument' => 'bar', 'id' => '?bar'])
  147. ;
  148. $pass = new RegisterControllerArgumentLocatorsPass();
  149. $pass->process($container);
  150. $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
  151. $locator = $container->getDefinition((string) $locator['foo:fooAction']->getValues()[0]);
  152. $expected = ['bar' => new ServiceClosureArgument(new TypedReference('bar', ControllerDummy::class, RegisterTestController::class, ContainerInterface::IGNORE_ON_INVALID_REFERENCE))];
  153. $this->assertEquals($expected, $locator->getArgument(0));
  154. }
  155. public function testSkipSetContainer()
  156. {
  157. $container = new ContainerBuilder();
  158. $resolver = $container->register('argument_resolver.service')->addArgument([]);
  159. $container->register('foo', ContainerAwareRegisterTestController::class)
  160. ->addTag('controller.service_arguments');
  161. $pass = new RegisterControllerArgumentLocatorsPass();
  162. $pass->process($container);
  163. $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
  164. $this->assertSame(['foo:fooAction'], array_keys($locator));
  165. }
  166. /**
  167. * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
  168. * @expectedExceptionMessage Cannot determine controller argument for "Symfony\Component\HttpKernel\Tests\DependencyInjection\NonExistentClassController::fooAction()": the $nonExistent argument is type-hinted with the non-existent class or interface: "Symfony\Component\HttpKernel\Tests\DependencyInjection\NonExistentClass". Did you forget to add a use statement?
  169. */
  170. public function testExceptionOnNonExistentTypeHint()
  171. {
  172. $container = new ContainerBuilder();
  173. $container->register('argument_resolver.service')->addArgument([]);
  174. $container->register('foo', NonExistentClassController::class)
  175. ->addTag('controller.service_arguments');
  176. $pass = new RegisterControllerArgumentLocatorsPass();
  177. $pass->process($container);
  178. }
  179. /**
  180. * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
  181. * @expectedExceptionMessage Cannot determine controller argument for "Symfony\Component\HttpKernel\Tests\DependencyInjection\NonExistentClassDifferentNamespaceController::fooAction()": the $nonExistent argument is type-hinted with the non-existent class or interface: "Acme\NonExistentClass".
  182. */
  183. public function testExceptionOnNonExistentTypeHintDifferentNamespace()
  184. {
  185. $container = new ContainerBuilder();
  186. $container->register('argument_resolver.service')->addArgument([]);
  187. $container->register('foo', NonExistentClassDifferentNamespaceController::class)
  188. ->addTag('controller.service_arguments');
  189. $pass = new RegisterControllerArgumentLocatorsPass();
  190. $pass->process($container);
  191. }
  192. public function testNoExceptionOnNonExistentTypeHintOptionalArg()
  193. {
  194. $container = new ContainerBuilder();
  195. $resolver = $container->register('argument_resolver.service')->addArgument([]);
  196. $container->register('foo', NonExistentClassOptionalController::class)
  197. ->addTag('controller.service_arguments');
  198. $pass = new RegisterControllerArgumentLocatorsPass();
  199. $pass->process($container);
  200. $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
  201. $this->assertSame(['foo:barAction', 'foo:fooAction'], array_keys($locator));
  202. }
  203. public function testArgumentWithNoTypeHintIsOk()
  204. {
  205. $container = new ContainerBuilder();
  206. $resolver = $container->register('argument_resolver.service')->addArgument([]);
  207. $container->register('foo', ArgumentWithoutTypeController::class)
  208. ->addTag('controller.service_arguments');
  209. $pass = new RegisterControllerArgumentLocatorsPass();
  210. $pass->process($container);
  211. $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
  212. $this->assertEmpty(array_keys($locator));
  213. }
  214. public function testControllersAreMadePublic()
  215. {
  216. $container = new ContainerBuilder();
  217. $resolver = $container->register('argument_resolver.service')->addArgument([]);
  218. $container->register('foo', ArgumentWithoutTypeController::class)
  219. ->setPublic(false)
  220. ->addTag('controller.service_arguments');
  221. $pass = new RegisterControllerArgumentLocatorsPass();
  222. $pass->process($container);
  223. $this->assertTrue($container->getDefinition('foo')->isPublic());
  224. }
  225. /**
  226. * @dataProvider provideBindings
  227. */
  228. public function testBindings($bindingName)
  229. {
  230. $container = new ContainerBuilder();
  231. $resolver = $container->register('argument_resolver.service')->addArgument([]);
  232. $container->register('foo', RegisterTestController::class)
  233. ->setBindings([$bindingName => new Reference('foo')])
  234. ->addTag('controller.service_arguments');
  235. $pass = new RegisterControllerArgumentLocatorsPass();
  236. $pass->process($container);
  237. $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
  238. $locator = $container->getDefinition((string) $locator['foo:fooAction']->getValues()[0]);
  239. $expected = ['bar' => new ServiceClosureArgument(new Reference('foo'))];
  240. $this->assertEquals($expected, $locator->getArgument(0));
  241. }
  242. public function provideBindings()
  243. {
  244. return [[ControllerDummy::class], ['$bar']];
  245. }
  246. public function testDoNotBindScalarValueToControllerArgument()
  247. {
  248. $container = new ContainerBuilder();
  249. $resolver = $container->register('argument_resolver.service')->addArgument([]);
  250. $container->register('foo', ArgumentWithoutTypeController::class)
  251. ->setBindings(['$someArg' => '%foo%'])
  252. ->addTag('controller.service_arguments');
  253. $pass = new RegisterControllerArgumentLocatorsPass();
  254. $pass->process($container);
  255. $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
  256. $this->assertEmpty($locator);
  257. }
  258. public function testBindingsOnChildDefinitions()
  259. {
  260. $container = new ContainerBuilder();
  261. $resolver = $container->register('argument_resolver.service')->addArgument([]);
  262. $container->register('parent', ArgumentWithoutTypeController::class);
  263. $container->setDefinition('child', (new ChildDefinition('parent'))
  264. ->setBindings(['$someArg' => new Reference('parent')])
  265. ->addTag('controller.service_arguments')
  266. );
  267. $pass = new RegisterControllerArgumentLocatorsPass();
  268. $pass->process($container);
  269. $locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
  270. $this->assertInstanceOf(ServiceClosureArgument::class, $locator['child:fooAction']);
  271. $locator = $container->getDefinition((string) $locator['child:fooAction']->getValues()[0])->getArgument(0);
  272. $this->assertInstanceOf(ServiceClosureArgument::class, $locator['someArg']);
  273. $this->assertEquals(new Reference('parent'), $locator['someArg']->getValues()[0]);
  274. }
  275. }
  276. class RegisterTestController
  277. {
  278. public function __construct(ControllerDummy $bar)
  279. {
  280. }
  281. public function fooAction(ControllerDummy $bar)
  282. {
  283. }
  284. protected function barAction(ControllerDummy $bar)
  285. {
  286. }
  287. }
  288. class ContainerAwareRegisterTestController implements ContainerAwareInterface
  289. {
  290. use ContainerAwareTrait;
  291. public function fooAction(ControllerDummy $bar)
  292. {
  293. }
  294. }
  295. class ControllerDummy
  296. {
  297. }
  298. class NonExistentClassController
  299. {
  300. public function fooAction(NonExistentClass $nonExistent)
  301. {
  302. }
  303. }
  304. class NonExistentClassDifferentNamespaceController
  305. {
  306. public function fooAction(\Acme\NonExistentClass $nonExistent)
  307. {
  308. }
  309. }
  310. class NonExistentClassOptionalController
  311. {
  312. public function fooAction(NonExistentClass $nonExistent = null)
  313. {
  314. }
  315. public function barAction(NonExistentClass $nonExistent = null, $bar)
  316. {
  317. }
  318. }
  319. class ArgumentWithoutTypeController
  320. {
  321. public function fooAction($someArg)
  322. {
  323. }
  324. }